if - Indie-Resource.com

pretender5552 · Post by **pretender5552** » Sat Jan 15, 2011 6:30 am

I tried to make an if statement so that if I had enough experience it would increase my level and give me five statadds but it isn't work for some reason can someone help

Code: Select all

<?php
include_once 'connect.php';
include_once 'bannerbox.php';
?>

<link href="style.css" rel="stylesheet" type="text/css" />

<div id="profile">;
<?php

$playerinfo="SELECT * from player where name='Bryan'";
$playerinfo2=mysql_query($playerinfo) or die((mysql_error()));
$playerinfo3=mysql_fetch_array($playerinfo2);

$level = $playerinfo3['level'];
$statadd = $playerinfo3['stadadd'];
$experienceneeded = $playerinfo3['experienceneeded'];
$experience = $playerinfo3['experience'];
$experience2 =  $experienceneeded - $experience;

$experienceneeded = ($playerinfo3['level'] * 30) * 1.5;
$experienceneeded="update player set energy='$experienceneeded' where name='Bryan'";
  mysql_query($experienceneeded) or die (mysql_error());

{
if ($experience >= $experienceneeded);
	 $updatelevel = $level + 1;
$updatelevel="update player set level='$updatelevel' where name='Bryan'";
  mysql_query($updatelevel) or die (mysql_error());	 
	 $updatestatadd = $statadd + 5;
$updatestatadd="update player set stadadd='$updatestatadd' where name='Bryan'";
  mysql_query($updatestatadd) or die (mysql_error());
}
else
{
exit;
}

{
if ($statadd > 0);
}
echo "<table border='1' width='1005' height='20' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b><center>" . $playerinfo3['name'] . "  --  Level:" . $playerinfo3['level'] . " -- Hacker</b></font></td></tr></table><br>";

echo "<table border='1' width='330' height='470' cellspacing='1' bordercolor=green><tr><td bgcolor='2e652e' align='left' valign='top' style='vertical-align:top'><img src='hacker.jpg' width='330' height='470' align='top'></td></tr></table>";
?>
<div id="nextlevel">;
<?php
echo "<table border='1' width='400' height='20' cellspacing='1' bordercolor=green><tr><td bgcolor='000000' align='left' valign='top' style='vertical-align:top'><font color='2bab4c'><b><center>You need " . $experience2 . " experience points to reach the next level</center></b></td></tr></table>";
?>
</div>

<div id="stats">;
<?php
echo "<table border='1' width='400' height='20' cellspacing='1' bordercolor=green><tr><td width='400' height='20' bgcolor='000000' align='left' valign='top' style='vertical-align:top'><font color='2bab4c'><b>Skill Points</b></td></tr>";
echo "<td bgcolor='000000' align='left' valign='top' style='vertical-align:top'><font color='2bab4c'><b><br>Energy " . $playerinfo3['maxenergy'] . " Do more missions</b>";
echo "<font color='2bab4c'><b><br><br>Tech " . $playerinfo3['maxtech'] . " Have more fights (2 points ea.)</b>";
echo "<font color='2bab4c'><b><br><br>Attack " . $playerinfo3['attack'] . " Be more effective in combat</b>";
echo "<font color='2bab4c'><b><br><br>Defence " . $playerinfo3['attack'] . " Survive longer in combat</b>";
echo "<font color='2bab4c'><b><br><br>Health " . $playerinfo3['maxhealth'] . " Survive longer in combat<br></b></td></tr></table>";
?>
</div>

<div id="fightstats">;
<?php
echo "<table width='400' border='1' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b>Fight Stats</td></tr></table>";
echo "<table width='400' border='1' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b><br>Ranking<br></b><font color='2bab4c'><br><b>Wins<br></b><font color='2bab4c'><b><br>Losses<br><br></b></td>";
echo "<td width='50%' bgcolor='000000' align='left' valign='top' style='vertical-align:top'><font color='2bab4c'><b><br><center>" . $playerinfo3['ranking'] . "</center></b>";
echo "<font color='2bab4c'><b><br><center>" . $playerinfo3['win'] . "</center></b>";
echo "<font color='2bab4c'><b><br><center>" . $playerinfo3['lose'] . "</center><br></b></td></tr></table>";
?>
</div>

<div id="weapon">;
<?php
echo "<table width='1005' border='1' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b><center>Weapons</center></td></tr></table>";
echo "<table width='1005' border='1' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b><br></b></td></tr></table>";
?>
</div>

<div id="specielitem">;
<?php
echo "<table width='1005' border='1' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b><center>Special Items</center></td></tr></table>";
echo "<table width='1005' border='1' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b><br></b></td></tr></table>";
?>
</div>

<div id="vehicle">;
<?php
echo "<table width='1005' border='1' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b><center>Vehicles</center></td></tr></table>";
echo "<table width='1005' border='1' cellspacing='1' bordercolor=green><tr><td bgcolor='000000'><font color='2bab4c'><b><br></b></td></tr></table>";
?>
</div>

PaxBritannia · Post by **PaxBritannia** » Sat Jan 15, 2011 6:58 am

Could I have the error messages?

pax.

pretender5552 · Post by **pretender5552** » Sat Jan 15, 2011 7:00 am

Right now I am getting this Parse error: syntax error, unexpected T_ELSE in /home/pretend2/public_html/player.php on line 30

PaxBritannia · Post by **PaxBritannia** » Sat Jan 15, 2011 7:28 am

It seems as if you fuddled up you if statements.

For example, this section stating at lines 25 -> 37:

Code: Select all

{
if ($experience >= $experienceneeded);
    $updatelevel = $level + 1;
$updatelevel="update player set level='$updatelevel' where name='Bryan'";
  mysql_query($updatelevel) or die (mysql_error());   
    $updatestatadd = $statadd + 5;
$updatestatadd="update player set stadadd='$updatestatadd' where name='Bryan'";
  mysql_query($updatestatadd) or die (mysql_error());
}
else
{
exit;
}

should be

Code: Select all

if ($experience >= $experienceneeded){

    $updatelevel = $level + 1;
    $updatelevel="update player set level='$updatelevel' where name='Bryan'";
    mysql_query($updatelevel) or die (mysql_error());   

    $updatestatadd = $statadd + 5;
    $updatestatadd="update player set stadadd='$updatestatadd' where name='Bryan'";
    mysql_query($updatestatadd) or die (mysql_error());

}else{
exit;
}

The way to do it is:

Code: Select all

if ($condition==TRUE){
    dothis();
}else{
    dothat();
}

Semicolons (;) aren't needed on every line (Who told you that?).
On constructs like IF, ELSE, SWITCH, they are not needed.

Also, they aren't needed at all on HTML. So outside your <?php ?> tags, you don't need to have semicolons at all.

So you want to look at Lines 39 -> 41

Code: Select all

{
if ($statadd > 0);
}

and where-ever you have semi-colons outside <?php ?> tags: (These are from 45->47)

Code: Select all

?>
<div id="nextlevel">;
<?php

After fixing those pesky things, everything should work! Good Luck!

pax.

Post by **Jackolantern** » Sat Jan 15, 2011 7:28 am

EDIT: Doh! Beaten to the punch lol

You need to clean up your IF statements. I am looking at this code:

Code: Select all

if ($experience >= $experienceneeded); //This if statement does nothing. It has no body
    $updatelevel = $level + 1; //These next lines always occur everytime the script runs. They are not in an IF statement
$updatelevel="update player set level='$updatelevel' where name='Bryan'";
  mysql_query($updatelevel) or die (mysql_error());    
    $updatestatadd = $statadd + 5;
$updatestatadd="update player set stadadd='$updatestatadd' where name='Bryan'";
  mysql_query($updatestatadd) or die (mysql_error());
} //I assume this is where you thought you were closing the IF statement
else //This will cause an error
{ //Not sure why a bracket is being opened here
exit;
}

{
if ($statadd > 0);
}

Refer to the comments I added. This is how IF statements should be written:

Code: Select all

if ($value >= 15)  {
     runSomeStatements($value);
     //do some more stuff if equal to or more than 15
} else if ($value < 15)  {
    runDifferentStatements($value);
    //do other stuff if less than 15
} else {
    //run some default code that doesn't depend on the value
}

You can place the opening bracket on the next line if you want, but most coders seem to put it on the same line. This is the other way:

Code: Select all

if ($value >= 15)  
{
     runSomeStatements($value);
     //do some more stuff if equal to or more than 15
} else if ($value < 15)  
{
    runDifferentStatements($value);
    //do other stuff if less than 15
} else 
{
    //run some default code that doesn't depend on the value
}

PaxBritannia · Post by **PaxBritannia** » Sat Jan 15, 2011 7:30 am

Less than a minute difference!

pax.

pretender5552 · Post by **pretender5552** » Sat Jan 15, 2011 7:33 am

I have just been trying to work out what I have learned from the videos started learning to code two weeks ago so am still pretty new to it

PaxBritannia · Post by **PaxBritannia** » Sat Jan 15, 2011 7:46 am

It's alright. We understand, we were all once there.

Frankly, that your new to scripting doesn't matter, you've already taken a large step.

Most people just wish they could make a game but don't do anything about it. There are some who just watch videos, and read about it but never actually write anything.

Give yourself a pat on the back. Well done! Now go and fix those bugs!

pax.

pretender5552 · Post by **pretender5552** » Sat Jan 15, 2011 7:48 am

Its not working though my statadd, level and experience aren't updating

PaxBritannia · Post by **PaxBritannia** » Sat Jan 15, 2011 7:52 am

Any error codes?

pax.

if

if

Re: if

Re: if

Re: if

Re: if

Re: if

Re: if

Re: if

Re: if

Re: if