Well.. I fixed those errors with your(community) help and now i have another question about OOP in PHP.
My main page for the village (its a village game) where you have all the buildings info and stuff, has more than 930 lines of code and the majority of those lines are like this :
To show the Palace Info
Code: Select all
echo "<tr><td><form method='post' action='palacio.php'><input type='hidden' name='villageid' value='$id'><input type='image' src='images/buildings/" . $age . "/" . $palacio_info['image'] . "' alt='Submit button'></form></td><td>" . $lang['Buildings_palacio_desc'][$language]
. "</td><td>"
. $lang['Buildings_cost_stone'][$language] . $palacio_cost_stone . "<br>"
. $lang['Buildings_cost_wood'][$language] . $palacio_cost_wood . "<br>"
. $lang['Buildings_cost_argila'][$language] . $palacio_cost_argila . "</td><td>"
. $lang['Aldeias_nivel'][$language] . $palacio . "<br>"
. $lang['Tempo'][$language] . round($palacio_tempo / 60,2) . "min
<form method ='post' action='aldeia.php'><input type='hidden' name='village_name' value='$nome'>
<input type='hidden' name='building' value='palacio'>
<input type='hidden' name='time' value='$palacio_tempo'>
<input type='hidden' name='aldeia' value='$id'>
<input type='hidden' name='cost_stone' value='$palacio_cost_stone'>
<input type='hidden' name='cost_wood' value='$palacio_cost_wood'>
<input type='hidden' name='cost_argila' value='$palacio_cost_argila'>
<input type='submit' style='height:2em; width:5em;' value='" . $lang['Buildings_Levelup'][$language] . "'>
</form>
</td><td></tr>";
Code: Select all
if($engenheiro)
{
echo "<tr><td><form method='post' action='engenheiro.php'><input type='hidden' name='village_id' value='$vil_id'><input type='image' src='images/buildings/" . $age . "/" . $engenheiro_info['image'] . "' alt='Submit button' name='bla' value='$vil_id'></form></td><td>" . $lang['Buildings_engenheiro_desc'][$language]
. "</td><td>"
. $lang['Buildings_cost_stone'][$language] . $engenheiro_cost_stone . "<br>"
. $lang['Buildings_cost_wood'][$language] . $engenheiro_cost_wood . "<br>"
. $lang['Buildings_cost_argila'][$language] . $engenheiro_cost_argila . "</td><td>"
. $lang['Aldeias_nivel'][$language] . $engenheiro . "<br>"
. $lang['Tempo'][$language] . round($engenheiro_tempo / 60,2) . "min
<form method ='post' action='aldeia.php'><input type='hidden' name='village_name' value='$nome'>
<input type='hidden' name='building' value='engenheiro'>
<input type='hidden' name='time' value='$engenheiro_tempo'>
<input type='hidden' name='aldeia' value='$id'>
<input type='hidden' name='cost_stone' value='$engenheiro_cost_stone'>
<input type='hidden' name='cost_wood' value='$engenheiro_cost_wood'>
<input type='hidden' name='cost_argila' value='$engenheiro_cost_argila'>
<input type='submit' style='height:2em; width:5em;'value='" . $lang['Buildings_Levelup'][$language] . "'>
</form>
</td><td></tr>";
}
else
{
echo "<tr><td><img src='images/buildings/" . $age . "/" . $engenheiro_info['image'] . "'></td><td>" . $lang['Buildings_engenheiro_desc'][$language]
. "</td><td>"
. $lang['Buildings_cost_stone'][$language] . $engenheiro_cost_stone . "<br>"
. $lang['Buildings_cost_wood'][$language] . $engenheiro_cost_wood . "<br>"
. $lang['Buildings_cost_argila'][$language] . $engenheiro_cost_argila . "</td><td>"
. $lang['Aldeias_nivel'][$language] . $engenheiro . "<br>"
. $lang['Tempo'][$language] . round($engenheiro_tempo / 60,2) . "min
<form method ='post' action='aldeia.php'><input type='hidden' name='village_name' value='$nome'>
<input type='hidden' name='building' value='engenheiro'>
<input type='hidden' name='time' value='$engenheiro_tempo'>
<input type='hidden' name='aldeia' value='$id'>
<input type='hidden' name='cost_stone' value='$engenheiro_cost_stone'>
<input type='hidden' name='cost_wood' value='$engenheiro_cost_wood'>
<input type='hidden' name='cost_argila' value='$engenheiro_cost_argila'>
<input type='submit' style='height:2em; width:5em;'value='" . $lang['Buildings_Construct'][$language] . "'>
</form>
</td><td></tr>";
}
Thank god i did it good at first.. at least i think so.
Well im here to ask you guys how can i make this more Object Oriented..
If you know C++ you will know what im talking about like to present this kind of information:
Code: Select all
void ShowInformation()
{
PalaceInfo();
EngineerInfo();
...etc
}